samskalicky commented on a change in pull request #17486: Update CustomOp doc 
with changes for GPU support
URL: https://github.com/apache/incubator-mxnet/pull/17486#discussion_r375020045
 
 

 ##########
 File path: example/extensions/lib_custom_op/README.md
 ##########
 @@ -56,87 +72,111 @@ For building a library containing your own custom 
operator, compose a C++ source
 - `forward` - Forward Computation (can be replace with `createOpState`, see 
below for details)
 
 Then compile it to `libmyop_lib.so` dynamic library using the following 
command:
+
 ```bash
 g++ -shared -fPIC -std=c++11 myop_lib.cc -o libmyop_lib.so -I 
../../../include/mxnet
 ```
 
+If you don't want to download MXNet source and choose only using `lib_api.h` 
header, you can copy the header over to the same folder of `myop_lib.cc` and 
run:
 
 Review comment:
   "choose only using" --> "choose to only use"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to