leezu commented on a change in pull request #15969: Partitioning Gluon 
HybridBlocks
URL: https://github.com/apache/incubator-mxnet/pull/15969#discussion_r375461369
 
 

 ##########
 File path: python/mxnet/gluon/block.py
 ##########
 @@ -1040,7 +1052,12 @@ def register_child(self, block, name=None):
         super(HybridBlock, self).register_child(block, name)
         self._clear_cached_op()
 
-    def hybridize(self, active=True, **kwargs):
+    def hybridize(self, active=True, backend=None, backend_args=None, 
**kwargs):
 
 Review comment:
   Based on prior discussion with @samskalicky, documentation should describe 
what happens if input shapes change in subsequent forward calls. (Ie. currently 
no repartitioning is triggered).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to