rondogency commented on a change in pull request #15969: Partitioning Gluon
HybridBlocks
URL: https://github.com/apache/incubator-mxnet/pull/15969#discussion_r375479382
##########
File path: python/mxnet/gluon/block.py
##########
@@ -1040,7 +1061,12 @@ def register_child(self, block, name=None):
super(HybridBlock, self).register_child(block, name)
self._clear_cached_op()
- def hybridize(self, active=True, **kwargs):
+ def hybridize(self, active=True, backend=None, backend_args=None,
**kwargs):
+ self._backend = backend
+ if backend_args is None:
+ self._backend_args = {}
Review comment:
I think default None is the safest option, anyway we don't need this line
we need to enforce users to pass a dictionary (since user may pass a
string), so we need to add a check below before assign it to _backend_args
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
