eric-haibin-lin commented on a change in pull request #17555: [MXNET-#16795] Byteps-KVStore: Intergrate Byteps into mxnet as new type of kvstore backend URL: https://github.com/apache/incubator-mxnet/pull/17555#discussion_r376827501
########## File path: tests/nightly/dist_device_sync_kvstore_byteps.py ########## @@ -0,0 +1,115 @@ +#!/usr/bin/env python + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import sys +sys.path.insert(0, "../../python/") +import mxnet as mx +import numpy as np +import numpy.random as rnd +import time +import argparse +from mxnet.log import get_logger +import logging +from mxnet.kvstore import BytePS +logger = get_logger("Byteps-Backend-Test", level=logging.DEBUG) + +# parser +parser = argparse.ArgumentParser(description='kvstore test') +parser.add_argument('--name', type=str, default='byteps') +args = parser.parse_args() + +def check_diff_to_scalar(A, x, rank=None): + """ assert A == x""" + assert(np.sum(np.abs((A - x).asnumpy())) == 0), (rank, A.asnumpy(), x) + +# setup +keys = ['3', '5', '7'] +init_test_keys = [str(i) for i in range(200,300)] +init_test_keys_big = [str(i) for i in range(300,400)] +init_test_keys_device = [str(i) for i in range(400,500)] +init_test_keys_device_big = [str(i) for i in range(500,600)] + +shape = (2, 3) +big_shape = (1200, 1200) # bigger than MXNET_KVSTORE_BIGARRAY_BOUND + +kv = mx.kv.create(args.name) +my_rank = kv.rank +my_num_workers = kv.num_workers + +has_gpu = mx.context.num_gpus() > 0 + +def current_context(device=False): + if has_gpu and device==True: + return mx.gpu(kv.local_rank) + else: + return mx.current_context() + +def test_pushpull(): + num_gpus = 2 + def check_default_keys(nrepeat=3): + # init kv dns keys + kv.broadcast('3', mx.nd.ones(shape, ctx=current_context(device=True)), mx.nd.ones(shape, ctx=current_context(device=True))) Review comment: I don't think there's a `device=True` argument for current_context. Does this test pass locally? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
