haojin2 commented on a change in pull request #17563: [Numpy] add isposinf isneginf isfinite URL: https://github.com/apache/incubator-mxnet/pull/17563#discussion_r377989798
########## File path: src/operator/numpy/np_elemwise_unary_op_basic.cc ########## @@ -92,6 +92,21 @@ bool NumpyUnaryLogicOpType(const nnvm::NodeAttrs& attrs, return true; } +bool NumpyUnaryBoolOpType(const nnvm::NodeAttrs& attrs, Review comment: I think you can directly replace `NumpyUnaryLogicOpType` above with this version ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
