pengzhao-intel commented on issue #16735: Use single-bit for mask in dropout operator URL: https://github.com/apache/incubator-mxnet/pull/16735#issuecomment-585555475 > > I'm ok with the result. @TaoLv any concern? > > It's still 1.36x slower. I will take another look today. > > > If sacrificing performance (to some extent) can help improve usability, I think we need to consider the trade off. > > As I mentioned above, I'm not taking this as a general usability issue. I don't think we want to sacrifice the performance on CPU while memory size is not a concern there. @pengzhao-intel It will be a concern for the performance drop because we are working on model training recently. I didn't follow up on all discussions in the thread. One quick question: Does the slow down come from more computation in the new algorithm or the sub-optimal implementation?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
