reminisce commented on a change in pull request #17530: Add deferred compute
support
URL: https://github.com/apache/incubator-mxnet/pull/17530#discussion_r378659684
##########
File path: include/mxnet/imperative.h
##########
@@ -88,6 +89,77 @@ class Imperative {
&& info.out_grads.size() == 1;
}
};
+
+ /*! \brief DCInfo datastructure to enable deferred computation */
+ class DCInfo {
+ public:
+ DCInfo() {
+ // Default constructor provided for the sake of any.h. Should not be
used.
+ throw std::invalid_argument("Unsupported default constructor");
+ }
Review comment:
This is probably not necessary since a constructor with arguments has been
defined below and will be used as the default constructor if you simply delete
this one. In that sense, any use like `DCInfo dcinfo` will generate an error at
compile time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
