apeforest commented on a change in pull request #17599: Fixed Embedding op for
LT input
URL: https://github.com/apache/incubator-mxnet/pull/17599#discussion_r379766442
##########
File path: src/operator/tensor/indexing_op.h
##########
@@ -66,7 +66,7 @@ enum QuantizedEmbeddingOpResource {kTempSpace};
struct SparseEmbeddingParam: public dmlc::Parameter<SparseEmbeddingParam> {
- int input_dim;
+ index_t input_dim;
int output_dim;
Review comment:
Would there be a case where output_dim also exceeds 2^32?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
