sxjscience commented on issue #17605: add npx.broadcast_like URL: https://github.com/apache/incubator-mxnet/pull/17605#issuecomment-586624730 Yes, we should add test cases. In fact, for the previous npx.gather_nd, we should also add test cases. ________________________________ From: Xi Wang <[email protected]> Sent: Saturday, February 15, 2020 1:12:53 AM To: apache/incubator-mxnet <[email protected]> Cc: Xingjian SHI <[email protected]>; Mention <[email protected]> Subject: Re: [apache/incubator-mxnet] add npx.broadcast_like (#17605) Hi @ZheyuYe<https://github.com/ZheyuYe> I strongly suggest you adding test cases for the zero-dim and zero-size cases. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-mxnet/pull/17605?email_source=notifications&email_token=ABHQH3QNUB33FVOW7IYIK73RC6WZLA5CNFSM4KVWVF52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL3FYTA#issuecomment-586570828>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABHQH3RKNEIKORE2VC5PFJTRC6WZLANCNFSM4KVWVF5Q>.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
