eric-haibin-lin commented on a change in pull request #8259: check_format of ndrray, mainly for csr URL: https://github.com/apache/incubator-mxnet/pull/8259#discussion_r145604923
########## File path: src/ndarray/ndarray.cc ########## @@ -1214,6 +1214,39 @@ void NDArray::SyncCopyToCPU(void *data, size_t size) const { } } +void NDArray::CheckFormat(const bool full_check) const { + mshadow::default_real_t err = kNormalErr; Review comment: Hmm, is the type `default_real_t ` intentional? kNormalErr is an enum which is usually a integer ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services