haojin2 commented on a change in pull request #17619: [numpy] add op fabs,
sometrue, round_
URL: https://github.com/apache/incubator-mxnet/pull/17619#discussion_r380530563
##########
File path: python/mxnet/ndarray/numpy/_op.py
##########
@@ -39,7 +39,7 @@
'average', 'mean', 'maximum', 'minimum',
'swapaxes', 'clip', 'argmax', 'argmin', 'std', 'var', 'indices',
'copysign', 'ravel', 'unravel_index',
'diag_indices_from', 'hanning', 'hamming', 'blackman', 'flip',
'flipud', 'fliplr', 'around', 'round',
- 'hypot', 'bitwise_and', 'bitwise_xor', 'bitwise_or', 'rad2deg',
'deg2rad', 'unique', 'lcm',
+ 'round_', 'hypot', 'bitwise_and', 'bitwise_xor', 'bitwise_or',
'rad2deg', 'deg2rad', 'unique', 'lcm',
Review comment:
maybe move this to the position after `around` and `round`, both in this
list and in the file. Same for all other files as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
