samskalicky commented on a change in pull request #17585: Dynamic subgraph
property doc
URL: https://github.com/apache/incubator-mxnet/pull/17585#discussion_r381115979
##########
File path: include/mxnet/lib_api.h
##########
@@ -1271,7 +1271,17 @@ extern "C" {
for (int i = 0; i < num_opts; i++) {
opts[std::string(opt_keys[i])] = std::string(opt_vals[i]);
}
- return supportedOps(subgraph_json, num_ids, ids, opts);
+ // create array of bools for operator support
+ std::vector<bool> _ids(num_ids, false);
+ // call user's supportedOps function
+ MXReturnValue retval = supportedOps(subgraph_json, _ids, opts);
+ if (!retval) return retval;
+
+ // copy bools in ids to ints
+ for (int i = 0; i < num_ids; i++)
Review comment:
technically no, but we would need to check. so might as well update anyway.
Remember that this happens only once for the model up-front.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
