apeforest commented on a change in pull request #17639: Set Ninja build generator in config.cmake instead of commmand line URL: https://github.com/apache/incubator-mxnet/pull/17639#discussion_r382414055
########## File path: docs/static_site/src/pages/get_started/osx_setup.md ########## @@ -110,13 +110,10 @@ the guide in [Math Library Selection](build_from_source#math-library-selection). ```bash rm -rf build mkdir -p build && cd build -cmake -GNinja -C ../config.cmake .. -cmake --build . --parallel 8 +cmake -C ../config.cmake .. Review comment: We have already asked users to `cp config/linux.cmake config.cmake` before this line of instruction. I think it's already very explicit that `config.cmake` will be used to generate the cmake build. This option seems redundant and may cause confusion if users by chance specify a different file other than config.cmake. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
