szha commented on a change in pull request #17376: [MXNET-1404] Implement
storage tagging, the first half of the memory profiler
URL: https://github.com/apache/incubator-mxnet/pull/17376#discussion_r382702032
##########
File path: include/mxnet/resource.h
##########
@@ -148,33 +153,38 @@ struct Resource {
* \brief Get space requested as mshadow Tensor in specified type.
* The caller can request arbitrary size.
*
- * \param shape the Shape of returning tensor.
- * \param stream the stream of retruning tensor.
+ * \param shape the Shape of returning tensor.
+ * \param stream the Stream of returning tensor.
+ * \parma name the Name of the operator requesting the resource.
* \return the mshadow tensor requested.
* \tparam xpu the device type of random number generator.
* \tparam ndim the number of dimension of the tensor requested.
*/
template<typename xpu, int ndim, typename DType>
inline mshadow::Tensor<xpu, ndim, DType> get_space_typed(
- mshadow::Shape<ndim> shape, mshadow::Stream<xpu> *stream) const {
+ mshadow::Shape<ndim> shape, mshadow::Stream<xpu> *stream,
+ const std::string &name =
+ MXNET_STORAGE_DEFAULT_NAME_FARG("temp_space")) const {
Review comment:
Let's just add GPU and leave out the stream for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
