HahTK commented on issue #17623: Dynamic subgraph compile support URL: https://github.com/apache/incubator-mxnet/pull/17623#issuecomment-590531101 @samskalicky : I'll let the reviewers go through the code in detail but from perusal and with the aux added the feature looks good. Things to think about in the future : 1. For backends with very long compile time, a weight_update function may be useful. It also serves as a path to dynamically swap models (if so desired). 2. Some backends may absorb the weights in to the bin itself. For those we should provide an option for the partitioner to remove the redundant weight nodes that have been fully absorbed into bins. The corner case would of course be weights that are only partly absorbed. This would reduce memory footprint and improve speed by avoid the need to shove around unused weights I think both of these items can be done in the future but just enumerating them here
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
