leezu commented on issue #17647: cmake: copy dnnl headers to include/mkldnn URL: https://github.com/apache/incubator-mxnet/pull/17647#issuecomment-590639354 Why not use symbolic link as for the other include files? With this PR, `include/mkldnn` looks as follows: ``` ls -l include/mkldnn ~/src/mxnet-master cp_dnnl_headers ip-172-31-95-96 total 8 lrwxrwxrwx 1 ubuntu ubuntu 36 Feb 25 01:46 dnnl.h -> ../../3rdparty/mkldnn/include/dnnl.h lrwxrwxrwx 1 ubuntu ubuntu 38 Feb 15 01:08 dnnl.hpp -> ../../3rdparty/mkldnn/include/dnnl.hpp -rw-rw-r-- 1 ubuntu ubuntu 2603 Feb 25 01:45 dnnl_config.h lrwxrwxrwx 1 ubuntu ubuntu 42 Feb 15 01:08 dnnl_types.h -> ../../3rdparty/mkldnn/include/dnnl_types.h -rw-rw-r-- 1 ubuntu ubuntu 1074 Feb 25 01:45 dnnl_version.h lrwxrwxrwx 1 ubuntu ubuntu 38 Feb 15 01:00 mkldnn.h -> ../../3rdparty/mkldnn/include/mkldnn.h lrwxrwxrwx 1 ubuntu ubuntu 40 Feb 15 01:08 mkldnn.hpp -> ../../3rdparty/mkldnn/include/mkldnn.hpp lrwxrwxrwx 1 ubuntu ubuntu 52 Feb 15 01:08 mkldnn_dnnl_mangling.h -> ../../3rdparty/mkldnn/include/mkldnn_dnnl_mangling.h lrwxrwxrwx 1 ubuntu ubuntu 44 Feb 15 01:00 mkldnn_types.h -> ../../3rdparty/mkldnn/include/mkldnn_types.h lrwxrwxrwx 1 ubuntu ubuntu 46 Feb 15 01:08 mkldnn_version.h -> ../../3rdparty/mkldnn/include/mkldnn_version.h ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
