connorgoggins commented on a change in pull request #17677: [Large Tensor] Fix
cumsum op
URL: https://github.com/apache/incubator-mxnet/pull/17677#discussion_r384235914
##########
File path: src/operator/numpy/np_cumsum-inl.h
##########
@@ -60,17 +60,17 @@ struct CumsumParam : public dmlc::Parameter<CumsumParam> {
struct cumsum_forward {
template<typename IType, typename OType>
- MSHADOW_XINLINE static void Map(int i,
+ MSHADOW_XINLINE static void Map(index_t i,
OType *out,
const IType *in,
- const int middle,
- const int trailing) {
- int left = i / trailing, right = i % trailing;
- int offset = left * middle * trailing + right;
+ const index_t middle,
+ const index_t trailing) {
+ index_t left = i / trailing, right = i % trailing;
+ index_t offset = left * middle * trailing + right;
const IType *lane_in = in + offset;
Review comment:
[Here](https://www.cct.lsu.edu/~rguidry/eclipse-doc36/org/eclipse/cdt/core/dom/ast/IType.html)
it's defined as an interface for all C and C++ types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
