TaoLv commented on a change in pull request #17702: Support projection feature
for LSTM on CPU (Only Inference)
URL: https://github.com/apache/incubator-mxnet/pull/17702#discussion_r386026898
##########
File path: src/operator/rnn.cc
##########
@@ -385,7 +399,9 @@ The definition of GRU here is slightly different from
paper but compatible with
})
.set_attr<mxnet::FInferShape>("FInferShape", RNNShape)
.set_attr<nnvm::FInferType>("FInferType", RNNType)
+#if MXNET_USE_MKLDNN == 1
Review comment:
Make sure you know that, if MKL-DNN is not used, FInferStorageType will not
be registered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
