hzfan commented on a change in pull request #17747: [Numpy] FFI for cumsum and
add
URL: https://github.com/apache/incubator-mxnet/pull/17747#discussion_r386796731
##########
File path: python/mxnet/_ffi/_ctypes/types.py
##########
@@ -32,14 +32,11 @@ class TypeCode(object):
NULL = 4
MXNET_TYPE = 5
MXNET_CONTEXT = 6
- ARRAY_HANDLE = 7
- OBJECT_HANDLE = 8
- MODULE_HANDLE = 9
- FUNC_HANDLE = 10
- STR = 11
- BYTES = 12
- NDARRAY_CONTAINER = 13
- NDARRAYHANDLE = 14
+ OBJECT_HANDLE = 7
+ STR = 8
+ BYTES = 9
+ PYARG = 10
Review comment:
Basically it designates a python argument to be returned. For example,
PythonArg(2) says the 2nd python argument should be returned.
It is introduced for `out`. If parameter `out` is not `None`, then `out`
should serve as the return value. Note that we should not return the `NDArray*`
specified by `out`, as it creates another `NDArrayBase` in frontend, and thus
one `NDArray*` in backend gets destructed twice by two frontend `NDArrayBase`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
