apeforest commented on a change in pull request #17735: Fix OpPerf in Master
URL: https://github.com/apache/incubator-mxnet/pull/17735#discussion_r387498647
##########
File path: benchmark/opperf/rules/default_params.py
##########
@@ -431,7 +433,7 @@
"delta" : DEFAULT_DELTA,
"lr" : DEFAULT_LR,
"lrs" : DEFAULT_LRS,
- "wds" : DEFAULT_LRS,
+ "wd" : DEFAULT_LR,
Review comment:
Yes, I think it's better to create a new var even if its value is the same
as other var. It improves readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
