hzfan commented on a change in pull request #17779: [Numpy] FFI Invocation for
Unary Ops
URL: https://github.com/apache/incubator-mxnet/pull/17779#discussion_r389303905
##########
File path: python/mxnet/ndarray/numpy/_op.py
##########
@@ -1933,7 +1933,7 @@ def _unary_func_helper(x, fn_array, fn_scalar, out=None,
**kwargs):
if isinstance(x, numeric_types):
return fn_scalar(x, **kwargs)
elif isinstance(x, NDArray):
- return fn_array(x, out=out, **kwargs)
Review comment:
Since legacy operators make heavy use of `_unary_func_helper`, what about
leave it as it was? We may have a new helper function for `_api_internal`,
which may support `*args` instead of `**kwargs`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
