hzfan commented on a change in pull request #17795: [Numpy] FFI for linalg ops
URL: https://github.com/apache/incubator-mxnet/pull/17795#discussion_r392019600
##########
File path: python/mxnet/numpy/linalg.py
##########
@@ -232,7 +232,7 @@ def svd(a):
return _mx_nd_np.linalg.svd(a)
-def cholesky(a):
+def cholesky(a, lower=True):
Review comment:
Seems official numpy does not support lower?
https://docs.scipy.org/doc/numpy/reference/generated/numpy.linalg.cholesky.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
