hzfan commented on a change in pull request #17811: add ffi full_like, binary
ops, benchmark test
URL: https://github.com/apache/incubator-mxnet/pull/17811#discussion_r392034583
##########
File path: python/mxnet/ndarray/numpy/_op.py
##########
@@ -1025,8 +1023,9 @@ def subtract(x1, x2, out=None, **kwargs):
* If only one of the inputs is floating number type, the result is
that type.
* If both inputs are of integer types (including boolean), not
supported yet.
"""
- return _ufunc_helper(x1, x2, _npi.subtract, _np.subtract,
_npi.subtract_scalar,
- _npi.rsubtract_scalar, out)
+ if isinstance(x1, numeric_types) and isinstance(x2, numeric_types):
+ _np.subtract(x1, x2, out=out)
Review comment:
`return _np.subtract(x1, x2, out=out)`. Same for other ops
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
