hzfan commented on a change in pull request #17759: [numpy] FFI for insert \
delete \ matmul etc.
URL: https://github.com/apache/incubator-mxnet/pull/17759#discussion_r392084711
##########
File path: src/operator/numpy/np_init_op.h
##########
@@ -62,6 +62,17 @@ struct NumpyEyeParam : public
dmlc::Parameter<NumpyEyeParam> {
MXNET_ADD_ALL_TYPES
.describe("Data-type of the returned array.");
}
+ void SetAttrDict(std::unordered_map<std::string, std::string>* dict) {
+ std::ostringstream N_s, M_s, k_s, dtype_s;
+ N_s << N;
+ M_s << M;
+ k_s << k;
+ dtype_s << dtype;
+ (*dict)["N"] = N_s.str();
+ (*dict)["M"] = M_s.str();
+ (*dict)["k"] = k_s.str();
+ (*dict)["dtype"] = dtype_s.str();
Review comment:
Please use `String2MXNetTypeWithBool` in `op_utils.h`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
