piiswrong commented on a change in pull request #8342: [WIP] 2bit gradient
compression
URL: https://github.com/apache/incubator-mxnet/pull/8342#discussion_r146099245
##########
File path: python/mxnet/gluon/trainer.py
##########
@@ -65,7 +74,10 @@ def __init__(self, params, optimizer,
optimizer_params=None, kvstore='device'):
"First argument must be a list or dict of Parameters, " \
"got list of %s."%(type(param)))
self._params.append(param)
-
+ if compress_params:
+ if not isinstance(compress_params, dict):
+ raise ValueError("compress_params needs to be a dictionary")
Review comment:
why does it have to be a dict?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
