ciyongch commented on a change in pull request #17313: Update 3rdparty/mkldnn
to v1.2.1
URL: https://github.com/apache/incubator-mxnet/pull/17313#discussion_r392792694
##########
File path: tests/cpp/operator/mkldnn_test.cc
##########
@@ -100,7 +100,7 @@ static void VerifyDefMem(const mkldnn::memory &mem) {
TEST(MKLDNN_UTIL_FUNC, MemFormat) {
// Check whether the number of format is correct.
- CHECK_EQ(mkldnn_format_tag_last, 131);
+ CHECK_EQ(mkldnn_format_tag_last, 152);
Review comment:
Where can we get this number? Or do we need to calculate this number
manually when upgrading to a new version of DNNL?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
