hubutui opened a new issue #17845: openmp in CMakeLists.txt needs to be updated
URL: https://github.com/apache/incubator-mxnet/issues/17845
 
 
   Currently, cmake check if 
`${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/openmp/CMakeLists.txt` exists, check 
[here](https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L430),
 then build openmp from source, which is always true, and cmake will never use 
openmp provided in system, check 
[here](https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L444)
 .  So these codes need to to reordered. Another issue, the minimum cmake 
version is 3.13, and according to cmake 
[doc](https://cmake.org/cmake/help/v3.13/module/FindOpenMP.html), 
`OpenMP_FOUND` is used, not `OPENMP_FOUND`, this 
[line](https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L446)
 needs to be updated, too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to