hzfan commented on a change in pull request #17831: [numpy] add new ffi for
column_stack and hstack
URL: https://github.com/apache/incubator-mxnet/pull/17831#discussion_r393404359
##########
File path: src/operator/nn/concat-inl.h
##########
@@ -55,6 +55,14 @@ struct ConcatParam : public dmlc::Parameter<ConcatParam> {
DMLC_DECLARE_FIELD(dim).set_default(1)
.describe("the dimension to be concated.");
}
+
+ void SetAttrDict(std::unordered_map<std::string, std::string>* dict) {
+ std::ostringstream ss;
+ ss << num_args;
+ (*dict)["num_args"] = ss.str();
+ ss << dim;
Review comment:
Please clear `ss` before it is used for the second param, or use two
`ostringstream` seperately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
