hzfan commented on a change in pull request #17385: [NumPy] add random.geometric op URL: https://github.com/apache/incubator-mxnet/pull/17385#discussion_r393584811
########## File path: src/api/operator/numpy/random/np_geometric_op.cc ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file np_geometric_op.cc + * \brief Implementation of the API of functions in src/operator/numpy/np_geometric_op.cc + */ +#include <mxnet/api_registry.h> +#include <mxnet/runtime/packed_func.h> +#include "../../utils.h" +#include "../../../../operator/numpy/random/np_geometric_op.h" + +namespace mxnet { + +MXNET_REGISTER_API("_npi.geometric") +.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) { + using namespace runtime; + const nnvm::Op* op = Op::Get("_npi_geometric"); + nnvm::NodeAttrs attrs; + op::NumpyGeometricParam param; + + NDArray* in = nullptr; + int num_inputs = 0; + + if (args[0].type_code() == kNull) { + param.prob = dmlc::nullopt; + } else if (args[0].type_code() == kNDArrayHandle) { + param.prob = dmlc::nullopt; + in = args[0].operator mxnet::NDArray *(); + num_inputs++; + } else { + param.prob = args[0].operator double(); // convert arg to T + } + + if (args[1].type_code() == kNull) { + param.size = dmlc::nullopt; + } else { + if (args[1].type_code() == kDLInt) { + param.size = mxnet::Tuple<int>(1, args[1].operator int64_t()); + } else { + param.size = mxnet::Tuple<int>(args[1].operator ObjectRef()); + } + } + + if (args[2].type_code() == kNull) { + param.dtype = mshadow::kFloat32; + } else { + param.dtype = String2MXNetTypeWithBool(args[2].operator std::string()); + } + attrs.parsed = std::move(param); + attrs.op = op; + SetAttrDict<op::InitOpParam>(&attrs); + if (args[3].type_code() != kNull) { + attrs.dict["ctx"] = args[3].operator std::string(); + } + + NDArray** inputs = in == nullptr ? nullptr : ∈ + + NDArray* out = args[4].operator mxnet::NDArray*(); + NDArray** outputs = out == nullptr ? nullptr : &out; + // set the number of outputs provided by the `out` arugment + int num_outputs = out != nullptr; + auto ndoutputs = Invoke(op, &attrs, num_inputs, inputs, &num_outputs, outputs); + if (out) { + // PythonArg(n) designates the nth python argument is to be returned. + // So suppose `out` is the 3rd positional argument, we use PythonArg(2) (0-based index) Review comment: Comments are inconsistent with code, please remove. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
