sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394047744
##########
File path: CMakeLists.txt
##########
@@ -1,5 +1,14 @@
cmake_minimum_required(VERSION 3.13)
+file(READ "include/mxnet/base.h" ver)
+string(REGEX MATCH "MXNET_MAJOR ([0-9]*)" _ ${ver})
+set(ver_major ${CMAKE_MATCH_1})
+string(REGEX MATCH "MXNET_MINOR ([0-9]*)" _ ${ver})
+set(ver_minor ${CMAKE_MATCH_1})
+string(REGEX MATCH "MXNET_PATCH ([0-9]*)" _ ${ver})
+set(ver_patch ${CMAKE_MATCH_1})
+set(_PROJECT_VERSION "${ver_major}.${ver_minor}.${ver_patch}")
Review comment:
missing "language"
https://cmake.org/cmake/help/latest/command/project.html
noy im not sure if need other changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
