piiswrong commented on a change in pull request #8342: [WIP] 2bit gradient compression URL: https://github.com/apache/incubator-mxnet/pull/8342#discussion_r146112984
########## File path: src/operator/contrib/two_bit_quantize.cc ########## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file two_bit_quantize.cc + * \brief registers quantize_2bit, dequantize_2bit + * and create_2bit operators with nnvm + */ +#include "./two_bit_quantize-inl.h" + +namespace mxnet { +namespace op { + +DMLC_REGISTER_PARAMETER(TwoBitParam); + +NNVM_REGISTER_OP(_contrib_quantize_2bit) +.describe(R"code(Quantize an input tensor into using 2bits for each value using +user-specified thresholds, while storing quantization error in residual array. + +The quantize_2bit operator takes 5 arguments and is called as follows: +`quantize_2bit(array, residual, out, neg_threshold, pos_threshold)`. Review comment: Also I don't see why these need to be exposed as operators. It looks like for now kvstore handles everything internally. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
