[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d

Mon, 23 Mar 2020 08:15:49 -0700 

TaoLv commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d 
and Pool3d/1d
URL: https://github.com/apache/incubator-mxnet/pull/17884#discussion_r396524720
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_pooling.cc
 ##########
 @@ -127,61 +116,139 @@ mkldnn::algorithm GetMKLDNNPoolAlgo(const PoolingParam 
&param) {
   }
 }
 
+void InitPoolingPrimitiveParams(const PoolingParam &param,
+                                const mkldnn::memory::desc &data_md,
+                                mkldnn::memory::dims *new_kernel,
 
 Review comment:
   How about pass-by-reference?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to