haojin2 commented on a change in pull request #17866: [Numpy] Add ffi for
np.sum, np.std, np.var and np.average
URL: https://github.com/apache/incubator-mxnet/pull/17866#discussion_r402010010
##########
File path: include/mxnet/runtime/ffi_helper.h
##########
@@ -99,6 +99,24 @@ class Integer: public ObjectRef {
MXNET_DEFINE_OBJECT_REF_METHODS(Integer, ObjectRef, IntegerObj)
};
+class FloatObj: public Object {
+ public:
+ double value;
+ static constexpr const uint32_t _type_index = TypeIndex::kFloat;
+ static constexpr const char* _type_key = "MXNet.Float";
+ MXNET_DECLARE_FINAL_OBJECT_INFO(FloatObj, Object)
+};
+
+class Float: public ObjectRef {
+ public:
+ explicit Float(double value,
+ ObjectPtr<IntegerObj>&& data = make_object<IntegerObj>()) {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
