wuxun-zhang commented on a change in pull request #17884: [MKL-DNN] Integrate
Conv3d and Pool3d/1d
URL: https://github.com/apache/incubator-mxnet/pull/17884#discussion_r405850533
##########
File path: src/operator/nn/mkldnn/mkldnn_base-inl.h
##########
@@ -153,9 +153,8 @@ static inline bool SupportMKLDNN(int dtype, const
mxnet::TShape &shape) {
// MKLDNN currently does not support 0-dim Tensor and 0-size Tensor
return false;
}
-
return (dtype == mshadow::kFloat32 || dtype == mshadow::kBfloat16) &&
- (ndim == 1 || ndim == 2 || ndim == 4);
Review comment:
No. This is not needed for this PR. We have already enabled mkldnn conv with
3D tensor previously.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
