haojin2 commented on a change in pull request #18020: [Numpy] Add op linalg.matrix_rank URL: https://github.com/apache/incubator-mxnet/pull/18020#discussion_r407018370
########## File path: python/mxnet/numpy/linalg.py ########## @@ -26,6 +26,47 @@ __all__ += fallback_linalg.__all__ Review comment: should we add `matrix_rank` to `__all__` as well? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
