zheng-da commented on a change in pull request #17984: Raise toolchain 
requirements for MXNet 2 
URL: https://github.com/apache/incubator-mxnet/pull/17984#discussion_r408305956
 
 

 ##########
 File path: src/operator/contrib/dgl_graph.cc
 ##########
 @@ -24,6 +24,9 @@
 #include <mxnet/operator_util.h>
 
 Review comment:
   DGL no longer depends on the contrib graph operators. I would suggest to 
deprecate this sampling operator and even remove it in MXNet 2.0. Please see my 
comment here. 
https://github.com/apache/incubator-mxnet/issues/16167#issuecomment-613160299

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to