leezu commented on a change in pull request #18025: [DEV] switch nose with 
pytest
URL: https://github.com/apache/incubator-mxnet/pull/18025#discussion_r409223358
 
 

 ##########
 File path: .github/workflows/os_x_staticbuild.yml
 ##########
 @@ -10,16 +10,16 @@ jobs:
         uses: actions/checkout@v2
       - name: Install Dependencies
         run: |
-          brew install nasm automake ninja libtool cmake pkgconfig protobuf
+          brew install nasm automake ninja libtool cmake pkgconfig protobuf 
hdf5 zlib
+          python3 -m pip install --user -r ci/docker/install/requirements
 
 Review comment:
   I suggest not to use `ci/docker/install/requirements` here but list the 
dependencies explicitly. Most of the things in `ci/docker/install/requirements` 
are not needed for this test and having a single requirements file used for a 
that is used from an opaque number of locations for an variety of purposes 
makes it very hard to maintain that file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to