haojin2 commented on a change in pull request #18049: [numpy] add numpy op 
fill_diagonal
URL: https://github.com/apache/incubator-mxnet/pull/18049#discussion_r409958567
 
 

 ##########
 File path: python/mxnet/ndarray/numpy/_op.py
 ##########
 @@ -7477,6 +7477,94 @@ def resize(a, new_shape):
     return _npi.resize_fallback(a, new_shape=new_shape)
 
 
+@set_module('mxnet.ndarray.numpy')
+def fill_diagonal(a, val, wrap=False):
+    """
+    Fill the main diagonal of the given array of any dimensionality.
+    For an array `a` with ``a.ndim >= 2``, the diagonal is the list of
+    locations with indices ``a[i, ..., i]`` all identical. This function
+    modifies the input array in-place, it does not return a value.
+    Parameters
 
 Review comment:
   one more blank line above

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to