marcoabreu edited a comment on issue #17889: Re-enable coverage on CI for GCC 
CPU builds
URL: https://github.com/apache/incubator-mxnet/pull/17889#issuecomment-615850612
 
 
   Actually the coverage is not stable at all. Look at this example report 
https://codecov.io/gh/apache/incubator-mxnet/pull/17905/changes which is based 
on #17905. The PR adds one new operator, but 132 files have coverage changes 
with a reported line changes in a four digit space. 
   
   That example is not ideal (although the lines changed have a coverage of 
>90%, so the author did a good job of adding test coverage for their new code), 
but I couldn't find a recent PR which had a successful CI run and was a NO-OP. 
Maybe just create a few empty PRs, make the CI runs succeed and then you will 
have a few clear reports which show you exactly which lines are not stable.
   
   Generally we can only consider the coverage report stable if that page 
reports 0 changes for runs which do not change anything. Otherwise, these 
numbers are misleading and will confuse the PR authors if we enable the 
publishing.
   
   
![image](https://user-images.githubusercontent.com/18629099/79636895-714c2e80-817b-11ea-98a9-2fcf88947d3f.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to