nickguletskii commented on issue #17177: [1.x] Fix incorrect calculation 
results when the C locale is set to a locale that uses commas as the decimal 
separator
URL: https://github.com/apache/incubator-mxnet/pull/17177#issuecomment-616103040
 
 
   > We already run the testsuite on 2 Linux platforms: Ubuntu and CentOS7. I 
suggest to switch the locale for the CentOS7 platform instead of introducing 
another nighlty build. @nickguletskii would you like to help open a PR to the 
master branch? You'd need to change this Dockerfile 
https://github.com/apache/incubator-mxnet/blob/master/ci/docker/Dockerfile.build.centos7_cpu
 
https://github.com/apache/incubator-mxnet/blob/master/ci/docker/Dockerfile.build.centos7_gpu
   
   Good idea! I've made a pull request that updates the CentOS CI jobs and 
changes the tests to respect the locale environment variables: #18097

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to