apeforest commented on issue #17882: URL: https://github.com/apache/incubator-mxnet/pull/17882#issuecomment-616859584
> > Please add more details in the PR description to explain the rationale of this change: > > @apeforest > > 1. Its there in the PR Heading. Additionally, its being done to improve BERT performance regression when using Large Tensor Build > 2. Leverages vectorization. Can't explain line by line as to how. Too much text to write. I can share a link about vectorization for reviewers to read. Let me know if you meant something else. I can write 1 line each for 3 cases which is necessary > 3. I didn't understand this question. Could you clarify what meant by side-effect. 1. The title tells readers this PR will change the performance of broadcast_axis. However, I am not familiar with which tricks/algorithms you employed to make it faster. It would greatly help people understand code if you could mention it in PR description with a few sentences or a pseudo code. 2. vectorization is a very general term. Please add more details here. You could even copy some of them from your code comment 3. Side effect means any downside or potential problem will this change. e.g. slow down with other inputs, or not supporting certain inputs, backward compatibility etc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
