rondogency commented on a change in pull request #17885:
URL: https://github.com/apache/incubator-mxnet/pull/17885#discussion_r411781628
##########
File path: Makefile
##########
@@ -686,21 +686,36 @@ pylint:
python3 -m pylint --rcfile=$(ROOTDIR)/ci/other/pylintrc
--ignore-patterns=".*\.so$$,.*\.dll$$,.*\.dylib$$" python/mxnet
# MXNet extension dynamically loading libraries
-EXT_LIBS = build/libcustomop_lib.so build/libsubgraph_lib.so
+EXT_LIBS = build/libcustomop_lib.so build/libtransposecsr_lib.so
build/libtransposerowsp_lib.so build/libsubgraph_lib.so build/libpass_lib.so
ifeq ($(USE_CUDA), 1)
EXT_LIBS += build/libcustomop_gpu_lib.so
endif
extension_libs: $(EXT_LIBS)
build/libcustomop_lib.so:
@mkdir -p $(@D)
+ $(CXX) -shared -fPIC -std=c++11
example/extensions/lib_custom_op/gemm_lib.cc -o /dev/null -I include/mxnet
$(CXX) -shared -fPIC -std=c++17
example/extensions/lib_custom_op/gemm_lib.cc -o $@ -I include/mxnet
+build/libtransposecsr_lib.so:
+ @mkdir -p $(@D)
+ $(CXX) -shared -fPIC -std=c++11
example/extensions/lib_custom_op/transposecsr_lib.cc -o /dev/null -I
include/mxnet
+ $(CXX) -shared -fPIC -std=c++17
example/extensions/lib_custom_op/transposecsr_lib.cc -o $@ -I include/mxnet
Review comment:
plus since this will only go into 1.7 where c++17 is not included, we
don't need this test at all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
