samskalicky commented on a change in pull request #17885:
URL: https://github.com/apache/incubator-mxnet/pull/17885#discussion_r412352205



##########
File path: example/extensions/lib_custom_op/README.md
##########
@@ -200,6 +208,9 @@ If the number of input and output tensors are fixed, you 
can use hard-coded numb
 * **inferType**: This function takes three arguments. The 1st argument is the 
attributes (same as above). The 2nd argument is the a list of input data types 
corresponding to the input tensors. The 3rd argument is the placeholder for 
output tensor data types you need to assign.
 For example, if this operator has one input and one output, and data type 
doesn’t change, then you can do `outtypes[0] = intypes[0]` to populate the data 
type.
 
+* **inferSType**: This function takes three arguments. The 1st argument is the 
attributes (same as above). The 2nd argument is the a list of input storage 
types corresponding to the input tensors. The 3rd argument is the placeholder 
for output storage types you need to assign.
+For example, if this operator has one input and one output, and data type 
doesn’t change, then you can do `outtypes[0] = intypes[0]` to populate the data 
type.

Review comment:
       We need a whole overview for Sparse. Maybe you can help us add another 
section to the readme about that




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to