leezu commented on a change in pull request #18189:
URL: https://github.com/apache/incubator-mxnet/pull/18189#discussion_r417582682
##########
File path: ci/docker/Dockerfile.build.ubuntu
##########
@@ -127,6 +127,11 @@ RUN /work/ubuntu_julia.sh
COPY install/ubuntu_perl.sh /work/
RUN /work/ubuntu_perl.sh
+# MXNetJS nightly needs emscripten for wasm
+COPY install/ubuntu_emscripten.sh /work/
+RUN /work/ubuntu_emscripten.sh
+ENV LLVM=/work/deps/emscripten-fastcomp/build/bin
Review comment:
I don't think you need this line? It's handled at
https://github.com/apache/incubator-mxnet/blob/4774e58f37ed65a3ca97e64280230974ba4cde7e/ci/docker/runtime_functions.sh#L1468
##########
File path: ci/docker/Dockerfile.build.ubuntu
##########
@@ -127,6 +127,11 @@ RUN /work/ubuntu_julia.sh
COPY install/ubuntu_perl.sh /work/
RUN /work/ubuntu_perl.sh
+# MXNetJS nightly needs emscripten for wasm
+COPY install/ubuntu_emscripten.sh /work/
Review comment:
`wasm` backend is upstream in llvm since version 8. We have version 10
available in this docker image. So you could delete all the
`emscripten-fastcomp` from this script, as `emscripten-fastcomp` is deprecated
and replaced by the upstream llvm support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
