apeforest commented on a change in pull request #18239:
URL: https://github.com/apache/incubator-mxnet/pull/18239#discussion_r420562090
##########
File path: src/operator/tensor/ordering_op-inl.h
##########
@@ -190,8 +191,8 @@ using namespace mshadow;
struct fill_ind_to_one {
- template<typename DType>
- MSHADOW_XINLINE static void Map(int i, const index_t* indices, DType* out) {
Review comment:
data type of `i` is `int`. Would this actually cause out of bound error
with large inputs?
##########
File path: src/operator/tensor/ordering_op-inl.h
##########
@@ -190,8 +191,8 @@ using namespace mshadow;
struct fill_ind_to_one {
- template<typename DType>
- MSHADOW_XINLINE static void Map(int i, const index_t* indices, DType* out) {
Review comment:
data type of `i` is `int`. Would this cause out of bound error with
large inputs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
