[GitHub] [incubator-mxnet] ys2843 commented on a change in pull request #18288: Website global search feature

[GitBox]

ys2843 commented on a change in pull request #18288:
URL: https://github.com/apache/incubator-mxnet/pull/18288#discussion_r425524968



##########
File path: docs/static_site/src/_includes/head.html
##########
@@ -5,14 +5,15 @@
   <link 
href="https://raw.githubusercontent.com/dmlc/web-data/master/mxnet/image/mxnet-icon.png";
 rel="icon" type="image/png">
   {%- seo -%}
   <script src="https://medium-widget.pixelpoint.io/widget.js";></script>
+  <link rel="stylesheet" 
href="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.css"; />
   <link rel="stylesheet" href="{{ "/assets/main.css" | relative_url }}">
   {%- feed_meta -%}
   {%- if jekyll.environment == 'production' and site.google_analytics -%}
     {%- include google-analytics.html -%}
   {%- endif -%}
-
   <script 
src="https://ajax.googleapis.com/ajax/libs/jquery/3.3.1/jquery.min.js";></script>
-
+  <script 
src="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.js";></script>

Review comment:
       Good question, I have just researched this CDN `www.jsdelivr.com` and 
based on its description about its [network](https://www.jsdelivr.com/network): 
   > Big network in China
   jsDelivr is the only public CDN with a valid ICP license issued by the 
Chinese government, and hundreds of locations directly in Mainland China.
   
   I think it should work just fine, might load faster than hosting locally. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org