connorgoggins commented on a change in pull request #18340:
URL: https://github.com/apache/incubator-mxnet/pull/18340#discussion_r426552946
##########
File path: docs/static_site/Makefile
##########
@@ -20,7 +20,7 @@ all: html
html:
mkdir -p build
cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll
build --config _config_prod.yml -d ../build/html && cd ..
- wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip &&
unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm
versions.zip
+ wget
https://mxnet-website-static-artifacts.s3.us-east-2.amazonaws.com/versions.zip
&& unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm
versions.zip
Review comment:
When ZIP artifacts are compiled on a Mac (as the current artifact is),
the `__MACOSX` folder is autogenerated when they are extracted. If future
versions of the artifact are compiled using a different OS, this won't cause
any problems since the `rm -rf` command will pass even if the specified folder
doesn't exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
