cbalint13 opened a new pull request #18357:
URL: https://github.com/apache/incubator-mxnet/pull/18357
## Description ##
1. I got error using trunk (when using libmxnet as shared lib), right at
```dlopen()```:
```libmxnet.so: undefined symbol
_ZN5mxnet2op16ElemwiseBinaryOp11DnsCsrCsrOpIN7mshadow3cpuENS0_10mshadow_op3mulEEEvRKN4nnvm9NodeAttrsERKNS_9OpContextERKNS_7NDArrayESG_NS_9OpReqTypeESG_b```
2. The PR fix proper ```include``` order and inline.
### Comments ###
See the ```UND``` flag.
**BEFORE**
```
[cbalint@yoda incubator-mxnet]$ readelf -Ws /usr/lib64/libmxnet.so | c++filt
| grep 'void mxnet::op::ElemwiseBinaryOp::DnsCsrCsrOp<mshadow::cpu,
mxnet::op::mshadow_op::mul>(nnvm::NodeAttrs const&, mxnet::OpContext const&,
mxnet::NDArray const&, mxnet::NDArray const&, mxnet::OpReqType, mxnet::NDArray
const&, bool)'
7613: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND void
mxnet::op::ElemwiseBinaryOp::DnsCsrCsrOp<mshadow::cpu,
mxnet::op::mshadow_op::mul>(nnvm::NodeAttrs const&, mxnet::OpContext const&,
mxnet::NDArray const&, mxnet::NDArray const&, mxnet::OpReqType, mxnet::NDArray
const&, bool)
5021: 0000000000013c80 10251 FUNC LOCAL DEFAULT 467 void
mxnet::op::ElemwiseBinaryOp::DnsCsrCsrOp<mshadow::cpu,
mxnet::op::mshadow_op::mul>(nnvm::NodeAttrs const&, mxnet::OpContext const&,
mxnet::NDArray const&, mxnet::NDArray const&, mxnet::OpReqType, mxnet::NDArray
const&, bool) [clone .isra.0]
5022: 00000000000007b4 1479 FUNC LOCAL DEFAULT 2652 void
mxnet::op::ElemwiseBinaryOp::DnsCsrCsrOp<mshadow::cpu,
mxnet::op::mshadow_op::mul>(nnvm::NodeAttrs const&, mxnet::OpContext const&,
mxnet::NDArray const&, mxnet::NDArray const&, mxnet::OpReqType, mxnet::NDArray
const&, bool) [clone .isra.0] [clone .cold]
```
**AFTER**
```
[cbalint@yoda incubator-mxnet]$ readelf -Ws /usr/lib64/libmxnet.so | c++filt
| grep 'void mxnet::op::ElemwiseBinaryOp::DnsCsrCsrOp<mshadow::gpu,
mxnet::op::mshadow_op::mul>(nnvm::NodeAttrs const&, mxnet::OpContext const&,
mxnet::NDArray const&, mxnet::NDArray const&, mxnet::OpReqType, mxnet::NDArray
const&, bool)'
54842: 000000000976c060 5099 FUNC WEAK DEFAULT 12 void
mxnet::op::ElemwiseBinaryOp::DnsCsrCsrOp<mshadow::gpu,
mxnet::op::mshadow_op::mul>(nnvm::NodeAttrs const&, mxnet::OpContext const&,
mxnet::NDArray const&, mxnet::NDArray const&, mxnet::OpReqType, mxnet::NDArray
const&, bool)
```
Thank You !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
