TaoLv commented on a change in pull request #18355:
URL: https://github.com/apache/incubator-mxnet/pull/18355#discussion_r427004904
##########
File path: CMakeLists.txt
##########
@@ -240,24 +240,26 @@ if(USE_MKLDNN)
set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /EHsc /Gy /MT")
endif()
- set(MKLDNN_BUILD_TESTS OFF CACHE INTERNAL "" FORCE)
- set(MKLDNN_BUILD_EXAMPLES OFF CACHE INTERNAL "" FORCE)
- set(MKLDNN_ARCH_OPT_FLAGS "" CACHE INTERNAL "" FORCE)
- set(MKLDNN_ENABLE_JIT_PROFILING OFF CACHE INTERNAL "" FORCE)
- set(MKLDNN_LIBRARY_TYPE STATIC CACHE INTERNAL "" FORCE)
- set(DNNL_ENABLE_CONCURRENT_EXEC ON CACHE INTERNAL "" FORCE)
-
- if(NOT USE_OPENMP)
+ function(load_mkldnn)
+ set(MKLDNN_BUILD_TESTS OFF CACHE INTERNAL "" FORCE)
+ set(MKLDNN_BUILD_EXAMPLES OFF CACHE INTERNAL "" FORCE)
+ set(MKLDNN_ARCH_OPT_FLAGS "" CACHE INTERNAL "" FORCE)
+ set(MKLDNN_ENABLE_JIT_PROFILING OFF CACHE INTERNAL "" FORCE)
+ set(MKLDNN_LIBRARY_TYPE STATIC CACHE INTERNAL "" FORCE)
+ set(DNNL_ENABLE_CONCURRENT_EXEC ON CACHE INTERNAL "" FORCE)
+
+ if(NOT USE_OPENMP)
set(MKLDNN_CPU_RUNTIME SEQ CACHE INTERNAL "" FORCE)
- endif()
-
- add_subdirectory(3rdparty/mkldnn)
+ endif()
+ set(CMAKE_INSTALL_INCLUDEDIR "${CMAKE_INSTALL_INCLUDEDIR}/mkldnn")
+ add_subdirectory(3rdparty/mkldnn)
+ endfunction()
+ load_mkldnn()
include_directories(3rdparty/mkldnn/include)
include_directories(${PROJECT_BINARY_DIR}/3rdparty/mkldnn/include)
add_definitions(-DMXNET_USE_MKLDNN=1)
list(APPEND mxnet_LINKER_LIBS dnnl)
- set(INSTALL_MKLDNN ON)
Review comment:
Why it's removed? @yzhliu FYI.
##########
File path: CMakeLists.txt
##########
@@ -240,24 +240,26 @@ if(USE_MKLDNN)
set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /EHsc /Gy /MT")
endif()
- set(MKLDNN_BUILD_TESTS OFF CACHE INTERNAL "" FORCE)
- set(MKLDNN_BUILD_EXAMPLES OFF CACHE INTERNAL "" FORCE)
- set(MKLDNN_ARCH_OPT_FLAGS "" CACHE INTERNAL "" FORCE)
- set(MKLDNN_ENABLE_JIT_PROFILING OFF CACHE INTERNAL "" FORCE)
- set(MKLDNN_LIBRARY_TYPE STATIC CACHE INTERNAL "" FORCE)
- set(DNNL_ENABLE_CONCURRENT_EXEC ON CACHE INTERNAL "" FORCE)
-
- if(NOT USE_OPENMP)
+ function(load_mkldnn)
Review comment:
Why need put them into a function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
