wkcn commented on a change in pull request #18379:
URL: https://github.com/apache/incubator-mxnet/pull/18379#discussion_r428988397
##########
File path: src/io/batchify.cc
##########
@@ -150,7 +150,7 @@ class StackBatchify : public BatchifyFunction {
}
int sbs = static_cast<int>(bs);
MSHADOW_TYPE_SWITCH_WITH_BOOL(dtype, DType, {
- _Pragma("omp parallel for num_threads(bs)")
+ #pragma omp parallel for num_threads(bs)
Review comment:
We can unify the macro like
```c++
#ifndef _MSC_VER
#define __pragma(id) _Pragma(#id)
#endif
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
